Thanks Bue! I will update the failing tests according to your description.
This means the pre-3.0 behavior of letsign is restored.
Van: liblouis-liblouisxml-bounce@xxxxxxxxxxxxx
[mailto:liblouis-liblouisxml-bounce@xxxxxxxxxxxxx] Namens Bue Vester-Andersen
Verzonden: donderdag 7 juli 2016 15:32
Aan: liblouis-liblouisxml@xxxxxxxxxxxxx
Onderwerp: [liblouis-liblouisxml] SV: For Bue: letsign in Danish
Hi Davy,
I have checked the log files, and all the failures are false. The pattern is
the same as previously described: a combination of letters is marked with the
contraction opcode, and gets a letsignn in the actual output. However, it is
expected to be without a letsign, and thus is marked as a failure.
I don't know how this happened in the first place. I guess the tests were
generated by Mesar Hameed before I started using the contraction opcode in the
tables, and then they probably never got changed.
Unfortunately, I can't generate the test harness at the moment. I will try to
make a new harness after the release of 3.0, as the current harness is very big
and contains more than 200,000 tests for each table.
In the meantime, you are of course free to correct the tests if it helps you. I
am sorry, I can't do it myself just now.
HTH Bue
Fra:
liblouis-liblouisxml-bounce@xxxxxxxxxxxxx<mailto:liblouis-liblouisxml-bounce@xxxxxxxxxxxxx>
[mailto:liblouis-liblouisxml-bounce@xxxxxxxxxxxxx] På vegne af Davy Kager
Sendt: 4. juli 2016 11:51
Til: 'liblouis-liblouisxml@xxxxxxxxxxxxx'
Emne: [liblouis-liblouisxml] Re: SV: Re: SV: For Bue: letsign in Danish
Hi Bue,
Please find the relevant log files attached. It would be great if you could
have a look at them this week. :)
Thanks,
Davy
Van:
liblouis-liblouisxml-bounce@xxxxxxxxxxxxx<mailto:liblouis-liblouisxml-bounce@xxxxxxxxxxxxx>
[mailto:liblouis-liblouisxml-bounce@xxxxxxxxxxxxx] Namens Bue Vester-Andersen
Verzonden: maandag 4 juli 2016 10:36
Aan:
liblouis-liblouisxml@xxxxxxxxxxxxx<mailto:liblouis-liblouisxml@xxxxxxxxxxxxx>
Onderwerp: [liblouis-liblouisxml] SV: Re: SV: For Bue: letsign in Danish
Hi Davy,
Yes, that is right. As far as I know, the effect of the contraction opcode is
to place a letsign before the operand and make sure no contraction takes place.
So, the examples from the log should be corrected. However, I don't think I am
currently able to run the tests in my setup. It would be nice if you could send
the fail logs to me. Then I will see what I can do.
Bue
Fra:
liblouis-liblouisxml-bounce@xxxxxxxxxxxxx<mailto:liblouis-liblouisxml-bounce@xxxxxxxxxxxxx>
[mailto:liblouis-liblouisxml-bounce@xxxxxxxxxxxxx] På vegne af Davy Kager
Sendt: 4. juli 2016 08:41
Til: 'liblouis-liblouisxml@xxxxxxxxxxxxx'
Emne: [liblouis-liblouisxml] Re: SV: For Bue: letsign in Danish
Hi Bue,
Thanks for the information, this is very helpful. Do I understand correctly
that you expect a letsign before the letters “sv”? And the same for the other
contractions.
Below are a few lines from the yaml test log. All the failures appear to follow
this pattern. Could I trouble you to have a look at these tests? There are 93
failures for 6-dot and 95 for 8-dot Danish braille. It would be appreciated if
you could fix these failures or give me the OK to add the letsign to these
cases. But if there are genuine failures we probably need to know about that
too.
From the test log for the 6-dot table:
Input: '-sv'
Expected: '⠤⠎⠧' (length 3)
Received: '⠤⠠⠎⠧' (length 4)
Diff: Expected '⠎' but received '⠠' in index 1
lou_checkyaml:./yaml/da-dk-g26-dictionary_harness.yaml:417: Failure
Input: 'ae'
Expected: '⠁⠑' (length 2)
Received: '⠠⠁⠑' (length 3)
Diff: Expected '⠁' but received '⠠' in index 0
lou_checkyaml:./yaml/da-dk-g26-dictionary_harness.yaml:7301: Failure
Input: 'alv'
Expected: '⠁⠇⠧' (length 3)
Received: '⠠⠁⠇⠧' (length 4)
Diff: Expected '⠁' but received '⠠' in index 0
lou_checkyaml:./yaml/da-dk-g26-dictionary_harness.yaml:11287: Failure
Thanks,
Davy
Van:
liblouis-liblouisxml-bounce@xxxxxxxxxxxxx<mailto:liblouis-liblouisxml-bounce@xxxxxxxxxxxxx>
[mailto:liblouis-liblouisxml-bounce@xxxxxxxxxxxxx] Namens Bue Vester-Andersen
Verzonden: donderdag 30 juni 2016 16:13
Aan:
liblouis-liblouisxml@xxxxxxxxxxxxx<mailto:liblouis-liblouisxml@xxxxxxxxxxxxx>
Onderwerp: [liblouis-liblouisxml] SV: For Bue: letsign in Danish
Hi Davy,
Sorry, but I haven't been doing much with the yaml tests yet. It is something I
need to look at when I have finished this round of Danish tables.
Actually, sv should be written with a letsign. In the Danish grade 2 tables, I
have the following:
word selv 234-1236
contraction sv
It is a case like the English example
word could 14-145
contraction cd
I have done it consequently with word contractions consisting of two or three
cells, even if I didn't know of any commonly used abbreviation with those
letters. You never know what people get to write (smile).
HTH Bue
Fra:
liblouis-liblouisxml-bounce@xxxxxxxxxxxxx<mailto:liblouis-liblouisxml-bounce@xxxxxxxxxxxxx>
[mailto:liblouis-liblouisxml-bounce@xxxxxxxxxxxxx] På vegne af Davy Kager
Sendt: 30. juni 2016 10:32
Til: 'liblouis-liblouisxml@xxxxxxxxxxxxx'
Emne: [liblouis-liblouisxml] For Bue: letsign in Danish
Hi Bue (and others),
I recently noticed a small oversight in the code dealing with letsign in
forward translation. I corrected this issue (see branch dkager_letsign), but
now the tests for Danish grade 2 fail.
It appears the tests do not expect a letsign before a multi-letter contraction.
For example sv is expected to come out as ⠎⠧ but liblouis generates ⠠⠎⠧.
I checked the last stable release of liblouis, v2.6.5, and there too the
letsign is added. The YAML tests mark such cases as xfail. In v3.0 they are no
longer marked as xfail and indeed they worked because of that small oversight.
It would be very helpful if an expert can clarify what’s going on here. There
seems to be nothing in the tables to suggest that the letsign should be
suppressed in these cases.
Thanks,
Davy
DISCLAIMER:
De informatie verzonden met dit e-mail bericht is uitsluitend bestemd voor de
geadresseerde. Indien u niet de beoogde geadresseerde bent, verzoeken wij u
vriendelijk dit aan de afzender te melden (of via:
info@xxxxxxxxxx<mailto:info@xxxxxxxxxx>) en het origineel en eventuele kopieën
te verwijderen.
The information sent in this e-mail is solely intended for the individual or
company to whom it is addressed. If you received this message in error, please
notify the sender immediately (or mail to
info@xxxxxxxxxx<mailto:info@xxxxxxxxxx>) and delete the original message and
possible copies.
DISCLAIMER:
De informatie verzonden met dit e-mail bericht is uitsluitend bestemd voor de
geadresseerde. Indien u niet de beoogde geadresseerde bent, verzoeken wij u
vriendelijk dit aan de afzender te melden (of via:
info@xxxxxxxxxx<mailto:info@xxxxxxxxxx>) en het origineel en eventuele kopieën
te verwijderen.
The information sent in this e-mail is solely intended for the individual or
company to whom it is addressed. If you received this message in error, please
notify the sender immediately (or mail to
info@xxxxxxxxxx<mailto:info@xxxxxxxxxx>) and delete the original message and
possible copies.
DISCLAIMER:
De informatie verzonden met dit e-mail bericht is uitsluitend bestemd voor de
geadresseerde. Indien u niet de beoogde geadresseerde bent, verzoeken wij u
vriendelijk dit aan de afzender te melden (of via:
info@xxxxxxxxxx<mailto:info@xxxxxxxxxx>) en het origineel en eventuele kopieën
te verwijderen.
The information sent in this e-mail is solely intended for the individual or
company to whom it is addressed. If you received this message in error, please
notify the sender immediately (or mail to
info@xxxxxxxxxx<mailto:info@xxxxxxxxxx>) and delete the original message and
possible copies.
DISCLAIMER:
De informatie verzonden met dit e-mail bericht is uitsluitend bestemd voor de
geadresseerde. Indien u niet de beoogde geadresseerde bent, verzoeken wij u
vriendelijk dit aan de afzender te melden (of via:
info@xxxxxxxxxx<mailto:info@xxxxxxxxxx>) en het origineel en eventuele kopieën
te verwijderen.
The information sent in this e-mail is solely intended for the individual or
company to whom it is addressed. If you received this message in error, please
notify the sender immediately (or mail to
info@xxxxxxxxxx<mailto:info@xxxxxxxxxx>) and delete the original message and
possible copies.
