[liblouis-liblouisxml] Re: Definition of MAXSTRING

  • From: Marc Mulcahy <marc@xxxxxxxxxxxxx>
  • To: liblouis-liblouisxml@xxxxxxxxxxxxx
  • Date: Wed, 15 Sep 2010 09:37:35 -0600

Hi All:

Sorry about this, this was my fault, as that logging patch was mine.  I'm not 
sure why the cross-compiler I used to build and test liblouis didn't flag this.

The problem appears to be that stderr isn't initialized when the global logFile 
variable is created, which makes sense.  This patch initializes logFile to 
NULL, and then sets it to stderr if it's NULL 
in logPrint.


On Sep 15, 2010, at 9:22 AM, John J. Boyer wrote:

> I have committed a fix for the dual definition of MAXSTRING I get the 
> error that the initializer is not constant also. Apologies for not 
> testing this more thoroughyly. I'm not sure what the fix is at the 
> moment.
> 
> John
> 
> On Wed, Sep 15, 2010 at 05:04:06PM +0200, Christian Egli wrote:
>> Hi all
>> 
>> The latest update in svn brought a change in the definition of
>> MAXSTRING. It is now defined as 512 instead of 256. I welcome this
>> change since it fixes the problem I had with very long table names.
>> However it appears that MAXSTRING is defined in louis.h and in
>> compileTranslationTable.c. Shouldn't there be only one definition?
>> 
>> Thanks
>> Christian
>> -- 
>> Christian Egli
>> Swiss Library for the Blind, Visually Impaired and Print Disabled
>> Grubenstrasse 12, CH-8045 Zürich, Switzerland
>> For a description of the software and to download it go to
>> http://www.jjb-software.com
> 
> -- 
> My websites:
> GodTouches Digital Ministry, Inc. http://www.godtouches.org
> Abilitiessoft, Inc. http://www.abilitiessoft.com
> Location: Madison, WI, USA
> 
> For a description of the software and to download it go to
> http://www.jjb-software.com


Other related posts: