[leiningen] Re: [PATCH 1/1] Fix worktree problems by relying on git for information
- From: Phil Hagelberg <phil@xxxxxxxxxx>
- To: leiningen@xxxxxxxxxxxxx
- Date: Fri, 06 Jul 2018 11:54:04 -0700
Rob Browning <rlb@xxxxxxxxxxxxxxxx> writes:
This fixes failures involving git worktrees, for example when trying
to run the tests. Relying on git should mean that lein doesn't have
to care whether or not worktrees are involved.
Sorry for the delay on this. Haven't had time to dedicate to leiningen
in a while.
I agree it's OK to remove the fallback for when git isn't installed at
this point, especially because it's only called when generating a pom,
which should only be relevant during deploy.
But causing the whole pom task to fail because git isn't installed
shouldn't happen for a project that doesn't have a .git directory.
Description: PGP signature
Other related posts: