On Sun, May 6, 2012 at 6:48 AM, Fernando Lemos <fernandotcl@xxxxxxxx> wrote:
Hi,
On Wed, May 2, 2012 at 2:20 PM, DR <drdarkraven@xxxxxxxxx> wrote:
All-in-one patch
Cool, but this is rather confusing. First, your commit message is now
"Above commits squashed", which makes no sense at all to someone
reading the i3 history (if the patch gets merged).
Second, it's not a trivial patch. Glancing over it, it looks like it
changes the meaning of some functions, renames some stuff. It's not
clear to me why those changes are being made.
Please describe it better. With Git, we generally use a short
description that really gets to the point. Then we skip a line and
write a detailed description of the commit. Take a lookat the commit
message for e114b3db, which introduces changes that need to be
explained.
If you're changing the IPC protocol, describe how you're changing it.
What exactly is being changed in the protocol? Is the change backwards
compatible? Why do we need it, i.e., what's the use case?
If you're doing this to change the IPC protocol, why are you touching
x.c? How does that change the way i3 works?
Also, if you feel that the commit message is getting too big, maybe
the patch needs to be split into smaller parts.
Regards,
