[hipl-users] Re: Bugs in HIPL Source

  • From: Kristian Slavov <kristian.slavov@xxxxxx>
  • To: hipl-users@xxxxxxxxxxxxx
  • Date: Wed, 04 Feb 2004 13:51:17 +0200

Simon Schuetz wrote:

> Hi,
> I encountered several problem when compiling and installing HIPL. I used
> SuSE 8.2, Debian Woody and Debian Testing as the base systems. Please
> see the bug report below. If I missed anything or did something wrong
> then please let me know.

Hi,

Thanks for the bug report.

> ##########################################################################
> BUG REPORT HIPL
> ##########################################################################
> 
> Using a SuSE 8.2, kernel 2.4.20, gcc-3.3, openssl-0.9.6i

The original Linux 2.4.20 does not compile cleanly with gcc-3.3.
The problems arise in files that are not part of the actual HIP code.


> ##################################
> Compile modules
> ##################################
> 
> $ make modules
> 
> ----------------------------------
> ERROR: in file 'net/ipv6/hip/db.c'
> ----------------------------------
> db.c: In function `hip_hadb_release_ex_db_access':
> db.c:2062: error: invalid type argument of `->'
> db.c: In function `hip_hadb_release_db_access':
> db.c:2076: error: invalid type argument of `->'
> 
> FIXED by applying the following changes:
> 
> line 2062: /*HIP_WRITE_UNLOCK_DB(hip_hadb);*/
>            HIP_WRITE_UNLOCK_DB(&hip_hadb);
> 
> line 2076: /*HIP_READ_UNLOCK_DB(hip_hadb);*/
>            HIP_READ_UNLOCK_DB(&hip_hadb);
> 
> 
> ----------------------------------------
> ERROR: in file 'net/ipv6/hip/security.c'
> ----------------------------------------
> security.c:369: error: `dh_table_unlock' undeclared (first use in this
> function)
> security.c:369: error: (Each undeclared identifier is reported only once
> security.c:369: error: for each function it appears in.)
> 
> FIXED: variable 'dh_table_unlock' must be named 'dh_table_lock' in line
> 369


These two are actually our bugs. The reason, we have not seen these bugs 
before, 
is that we don't have access to an SMP machine.
We can't predict, how well (if at all) HIP will work in such systems.


> 
> 
> ##################################
> Install modules
> ##################################
> 
> -------------------------
> ERROR: unresolved symbols
> -------------------------
> depmod: *** Unresolved symbols in
> /lib/modules/2.4.20/kernel/net/ipv6/hip/hipmod.o
> depmod:         addrconf_lock


> Tried to FIX: This symbol is included in the Kernel option
>   Network opritons -> IPv6: Mobility Support (Correspondent Node)
>   To enable this option, option 'Network packet filtering (replaces
> ipchains)
>   has to be enabled first.


Don't do this. The next patch (-36) will fix this.
The problem was that the addconf_lock symbol was not defined if mobilitity 
support was not enabled. So I changed it so that if HIP support is enabled then 
the addrconf_lock symbol will be defined (exported).

Could you download the latest tarball from the webpage and test it on your SMP 
system? I tested that it compiles with gcc 2.95.4.

BR,
-- 
Kristian Slavov
Pohjoiskaari 8 B 43, 00200 Helsinki, Finland
GSM: +358-40-7220960


Other related posts: