[hipl-dev] Re: [Merge] lp:~hipl-core/hipl/hipv2-dh-ecdh into lp:hipl
- From: Christof Mroz <christof.mroz@xxxxxxxxxxxxxx>
- To: mp+131786@xxxxxxxxxxxxxxxxxx
- Date: Sun, 28 Oct 2012 18:50:24 -0000
Review: Approve
On 28.10.2012 17:35, Miika Komu wrote:
> We need this code for HIPv2. At the moment, I don't have much time to
> restructure/modularize/rewrite the entire branch, so please no generic or
> high level comments, only specific ones! Thanks.
I looked through your recent commits but not the whole thing.
> + for (j = 0; j < HIP_DH_GROUP_LIST_SIZE; j++) {
> + group_id = HIP_DH_GROUP_LIST[j];
> + for (i = 0; i < HIP_R1TABLESIZE; i++) {
> + cookie_k = get_cookie_difficulty();
> + hip_msg_init(&id_entry->r1_v2[j][i].buf.msg);
> +
> + if (hip_create_r1_v2(&id_entry->r1_v2[j][i].buf.msg, hit, sign,
> + privkey, pubkey, cookie_k, group_id)) {
> + HIP_ERROR("Unable to precreate R1_v2\n");
> + return -1;
> + }
> + HIP_DEBUG("R1_v2 Packets %d created for group: %d\n", i,
> group_id);
> + }
> + }
Looks good now, as long as the array bounds for id_entry->r1_v2 and
HIP_DH_GROUP_LIST match.
On a minor note, the assignment to cookie_k could be moved out of the loop (and
another one in the same function) unless get_cookie_difficulty() is randomized
in some sense.
--
https://code.launchpad.net/~hipl-core/hipl/hipv2-dh-ecdh/+merge/131786
Your team HIPL core team is subscribed to branch lp:hipl.
Other related posts:
