[hipl-dev] Re: [Merge] lp:~hipl-core/hipl/android-port-new into lp:hipl
- From: Diego Biurrun <diego@xxxxxxxxxx>
- To: hipl-dev@xxxxxxxxxxxxx
- Date: Fri, 22 Nov 2013 13:55:10 -0800
On Fri, Nov 22, 2013 at 02:27:49PM +0200, Juhani Toivonen wrote:
> On 22 Nov 2013, at 05:49, Diego Biurrun <diego@xxxxxxxxxx> wrote:
> > On Tue, Nov 19, 2013 at 12:49:31PM -0000, Juhani Toivonen wrote:
> >>
> >> These changes allow hipd and hipconf to be compiled for Android. This does
> >> not produce standard installable .apk packages, but contains instructions
> >> on how to prepare an Android device and install hipd and hipconf on it.
> >> hipfw under Android is currently not supported.
> >
> > What happens with hipfw?
>
> I’ll work on that later. Right now it doesn’t compile on android.
Is there a point in making it work on Android?
> >> The borrowed file android/ifaddrs.c has been changed so that the return
> >> value for malloc() is always checked and information of the error is
> >> carried over to the part of hipl using this file.
>
> btw, the author of the android/ifaddrs.c file accepted my changes to his
> source.
Good.
> > What happened to the idea of eliminating the *ifaddr calls instead?
>
> Remains on the todo list. To your previous words about where it’s used, the
> "giant hack": https://bugs.launchpad.net/hipl/+bug/697214
Hmmm? It seems to me it is only used in libhipl/netdev.c.
Anyway, replacing the ifaddr calls with a bit of netlink should not
be that hard. It's a much, much better solution than adding more
local ifaddr hacks.
Diego
Other related posts:
