[hipl-dev] Re: [Branch ~toxedvirus/hipl/options] Rev 5276: Rewrite module disabling.

  • From: Diego Biurrun <diego@xxxxxxxxxx>
  • To: hipl-dev@xxxxxxxxxxxxx
  • Date: Tue, 21 Dec 2010 13:52:56 +0100

On Fri, Dec 17, 2010 at 02:45:46PM +0000, noreply@xxxxxxxxxxxxx wrote:
> ------------------------------------------------------------
> revno: 5276
> committer: Andrius Bentkus <andrius.bentkus@xxxxxxxxxxxxxx>
> branch nick: options
> timestamp: Fri 2010-12-17 14:58:54 +0100
> message:
>   Rewrite module disabling.
>   
> --- modules/heartbeat/module_info.xml 2010-08-20 14:34:13 +0000
> +++ modules/heartbeat/module_info.xml 2010-12-17 13:58:54 +0000
> @@ -13,5 +13,6 @@
>      <application
>          name="hipd"
>          header_file="modules/heartbeat/hipd/heartbeat.h"
> -        init_function="hip_heartbeat_init" />
> +        init_function="hip_heartbeat_init"
> +        default_startup="yes" />

This XML nonsense gets crazier by the day...

> --- process_modules.py        2010-12-10 17:50:55 +0000
> +++ process_modules.py        2010-12-17 13:58:54 +0000
> @@ -67,6 +67,7 @@
>          name = str(current_app.attributes['name'].value)
>          app_info['header_file'] = 
> str(current_app.attributes['header_file'].value)
>          app_info['init_function'] = 
> str(current_app.attributes['init_function'].value)
> +        app_info['default_startup'] = 
> str(current_app.attributes['default_startup'].value)

Vertical alignment would help readability here IMO.

Diego

Other related posts: