[hipl-dev] Re: [Branch ~hipl-core/hipl/trunk] Rev 5192: Updated maintainer script

  • From: Miika Komu <mkomu@xxxxxxxxx>
  • To: hipl-dev@xxxxxxxxxxxxx
  • Date: Tue, 30 Nov 2010 17:22:31 +0200

Hi,

On 11/29/2010 11:32 AM, Diego Biurrun wrote:
On Fri, Nov 26, 2010 at 09:29:31PM +0000, noreply@xxxxxxxxxxxxx wrote:
------------------------------------------------------------
revno: 5192
committer: Miika Komu<miika@xxxxxx>
branch nick: trunk
timestamp: Fri 2010-11-26 23:27:47 +0200
message:
   Updated maintainer script

   Rationalized naming convention of variables. Corrected bzr repository
   address when fetching new it for the first time and fixed a missing
   directory change.
modified:
   tools/maintainer/bzr-update-hipl

--- tools/maintainer/bzr-update-hipl    2010-11-26 20:14:54 +0000
+++ tools/maintainer/bzr-update-hipl    2010-11-26 21:27:47 +0000
@@ -6,7 +6,7 @@

  # Use abs dir names in TMP_DIR, WWW_DIR and OUTPUT_FILE
  TMP_DIR=~/.bzr-hipl-cache
-REVISION=trunk
+BRANCH=trunk
  WWW_DIR=/var/www/infrahip/html/hipl
  OUTPUT_FILE=$WWW_DIR/hipl.tar.gz
  CHANGE_LOG_FILE=/tmp/ChangeLog

Creating the changelog in /tmp with a predictable name is a security
hole.  Just create it in $TMP_DIR instead.

@@ -16,14 +16,16 @@
      mkdir $TMP_DIR
+    cd $TMP_DIR
      bzr init-repo hipl-bzr
      cd hipl-bzr
-    bzr checkout file:///var/archive/hipl-bzr/$REVISION
-    cd $REVISION
+    bzr checkout lp:hipl
+    mv hipl $BRANCH

Just do this in one go:

   bzr checkout lp:hipl $BRANCH

thanks, done.

Other related posts: