[hipl-dev] Re: [Branch ~hipl-core/hipl/mobility-fixes] Rev 5183: fixed alignment, spelling and incorporated feedback from mailinglist
- From: Diego Biurrun <diego@xxxxxxxxxx>
- To: hipl-dev@xxxxxxxxxxxxx
- Date: Tue, 23 Nov 2010 15:54:51 +0100
On Tue, Nov 23, 2010 at 02:41:02PM +0000, noreply@xxxxxxxxxxxxx wrote:
> ------------------------------------------------------------
> revno: 5183
> committer: Rene Hummen <rene.hummen@xxxxxxxxxxxxxxxxx>
> branch nick: mobility-fixes
> timestamp: Tue 2010-11-23 15:38:13 +0100
> message:
> fixed alignment, spelling and incorporated feedback from mailinglist
>
> --- modules/update/hipd/update.c 2010-11-22 14:03:57 +0000
> +++ modules/update/hipd/update.c 2010-11-23 14:38:13 +0000
> @@ -689,18 +690,17 @@
>
> if (type == HIP_LOCATOR_LOCATOR_TYPE_UDP) {
> address_pointer += sizeof(struct hip_locator_info_addr_item2);
> - amount += 1;
> - } else if (type == HIP_LOCATOR_LOCATOR_TYPE_ESP_SPI) {
> - address_pointer += sizeof(struct hip_locator_info_addr_item);
> - amount += 1;
> - } else if (type == HIP_LOCATOR_LOCATOR_TYPE_IPV6) {
> - address_pointer += sizeof(struct hip_locator_info_addr_item);
> - amount += 1;
> + loc_count += 1;
> + } else if (type == HIP_LOCATOR_LOCATOR_TYPE_ESP_SPI
> + || type == HIP_LOCATOR_LOCATOR_TYPE_IPV6) {
> +
> + address_pointer += sizeof(struct hip_locator_info_addr_item);
> + loc_count += 1;
Indentation is off and the empty line looks odd. If you put the || at
the end of the line, the conditions will line up and be extra readable.
Diego
Other related posts:
