[hipl-dev] Re: [Branch ~hipl-core/hipl/mobility-fixes] Rev 5171: moved parameter building functions for mobility to update module
- From: Diego Biurrun <diego@xxxxxxxxxx>
- To: hipl-dev@xxxxxxxxxxxxx
- Date: Fri, 19 Nov 2010 20:26:33 +0100
On Fri, Nov 19, 2010 at 05:09:32PM +0000, noreply@xxxxxxxxxxxxx wrote:
> ------------------------------------------------------------
> revno: 5171
> committer: Rene Hummen <rene.hummen@xxxxxxxxxxxxxxxxx>
> branch nick: mobility-fixes
> timestamp: Fri 2010-11-19 18:07:10 +0100
> message:
> moved parameter building functions for mobility to update module
Just some nits I noticed while shedding a glance on this...
> --- lib/core/builder.c 2010-11-15 12:40:48 +0000
> +++ lib/core/builder.c 2010-11-19 17:07:10 +0000
> @@ -1089,7 +1089,7 @@
> * @param contents_size size of the contents after type and length fields
> * (in host byte order)
> */
> -static void hip_calc_param_len(struct hip_tlv_common *tlv_common,
> +void hip_calc_param_len(struct hip_tlv_common *tlv_common,
> hip_tlv_len_t contents_size)
Indentation is now off.
> --- modules/update/hipd/update_builder.c 1970-01-01 00:00:00 +0000
> +++ modules/update/hipd/update_builder.c 2010-11-19 17:07:10 +0000
> +
> +int hip_build_param_ack(struct hip_common *msg, uint32_t peer_update_id)
> +{
> + int err = 0;
> + struct hip_ack ack;
> +
> + hip_set_param_type((struct hip_tlv_common *) &ack, HIP_PARAM_ACK);
> + hip_calc_param_len((struct hip_tlv_common *) &ack,
> + sizeof(struct hip_ack));
Indentation is off.
> --- modules/update/hipd/update_builder.h 1970-01-01 00:00:00 +0000
> +++ modules/update/hipd/update_builder.h 2010-11-19 17:07:10 +0000
> @@ -0,0 +1,44 @@
> +
> +#ifndef MODULES_UPDATE_UPDATE_BUILDER_H_
> +#define MODULES_UPDATE_UPDATE_BUILDER_H_
We use the full path as guard in other files and no trailing underscore.
Diego
Other related posts:
