[hipl-commit] [trunk] Rev 4739: firewall: fix some signedness issues.

  • From: Mircea Gherzan <mircea.gherzan@xxxxxxxxxxxxxx>
  • To: hipl-commit@xxxxxxxxxxxxx
  • Date: Wed, 9 Jun 2010 16:16:30 +0300

Committer: Mircea Gherzan <mircea.gherzan@xxxxxxxxxxxxxx>
Date: 09/06/2010 at 16:16:30
Revision: 4739
Revision-id: mircea.gherzan@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
Branch nick: trunk

Log:
  firewall: fix some signedness issues.

Modified:
  M  firewall/esp_prot_conntrack.c
  M  firewall/esp_prot_fw_msg.c

=== modified file 'firewall/esp_prot_conntrack.c'
--- firewall/esp_prot_conntrack.c       2010-06-02 11:14:17 +0000
+++ firewall/esp_prot_conntrack.c       2010-06-09 13:16:09 +0000
@@ -292,7 +292,7 @@
     int hash_length                         = 0;
     // assume not found
     int err                                 = 0;
-    int element_index                       = 0;
+    unsigned  element_index                 = 0;
     int found                               = 0;
     long i;
 
@@ -1138,7 +1138,7 @@
             /* calculate difference of SEQ no in order to determine how many 
hashes
              * we have to calculate */
             if (ntohl(esp->esp_seq) - esp_tuple->seq_no > 0 &&
-                ntohl(esp->esp_seq) - esp_tuple->seq_no <= window_size) {
+                ntohl(esp->esp_seq) - esp_tuple->seq_no <= 
(unsigned)window_size) {
                 HIP_DEBUG("seq number within verification window\n");
 
                 num_verify = ntohl(esp->esp_seq) - esp_tuple->seq_no;

=== modified file 'firewall/esp_prot_fw_msg.c'
--- firewall/esp_prot_fw_msg.c  2010-05-31 09:44:40 +0000
+++ firewall/esp_prot_fw_msg.c  2010-06-09 13:16:09 +0000
@@ -53,7 +53,7 @@
     hash_tree_t *htree        = NULL;
     unsigned char *anchor     = NULL;
     int err                   = 0;
-    int j                     = 0;
+    unsigned  j               = 0;
     uint8_t i                 = 0;
     int hash_item_length      = 0;

Other related posts:

  • » [hipl-commit] [trunk] Rev 4739: firewall: fix some signedness issues. - Mircea Gherzan