[haiku-webkit-commits] Re: r585 - webkit/trunk/WebKit/haiku/WebPositive/autocompletion

  • From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-webkit-commits@xxxxxxxxxxxxx
  • Date: Sat, 31 Mar 2012 10:09:56 +0200

On 03/31/2012 04:19 AM, noreply@xxxxxxxxxxxx wrote:
+       if ((!target || message->FindString("bytes",&bytes) != B_OK
+                       || message->FindInt32("modifiers",&modifiers) != B_OK)
+               || modifiers != 0) {

Testing against 0 is probably not a good idea, at least IIRC the num lock, and scroll lock are also modifiers (ie. you might want to mask out them?).

Bye,
   Axel.

Other related posts: