[haiku-webkit-commits] Re: r560 - webkit/trunk/WebKit/haiku/WebPositive

  • From: Rene Gollent <anevilyak@xxxxxxxxx>
  • To: haiku-webkit-commits@xxxxxxxxxxxxx
  • Date: Tue, 28 Dec 2010 13:28:05 -0500

On Tue, Dec 28, 2010 at 1:21 PM, Ryan Leavengood <leavengood@xxxxxxxxx> wrote:
> Yeah my keyboard layout also requires shift for + (and so do most or
> all American keyboards.) I think you are right because it has made me
> remember an old debugging session when trying to figure this out for
> ShowImage. I may just add the command-= shortcut as an alias to "fix"
> this.

I honestly would rather see it fixed right, adding an alias to mask
the problem on one particular keymap would just make it even more
confusing to debug further down the road. The question is just the
best approach to fixing this one. A naive approach might be that, if
the shift key is held, but no match is found with that set of
modifiers, look for matches without the shift modifier. Though we
might have the same problem on layouts that require Alt Gr or other
dead keys to produce the character the menu item wants. Axel, Stephan,
any thoughts?



Other related posts: