[haiku-development] [hda] Duplicated condition

  • From: "Máximo Castañeda" <dmarc-noreply@xxxxxxxxxxxxx> (Redacted sender "antiswen" for DMARC)
  • To: "haiku-development@xxxxxxxxxxxxx" <haiku-development@xxxxxxxxxxxxx>
  • Date: Mon, 13 Jul 2020 15:54:44 +0000 (UTC)

I won't claim to know what the code is doing or supposed to do, just noticed a 
warning that looks like a real error.

-Wduplicated-cond warns about a sequence of tests in 
src/add-ons/kernel/drivers/audio/hda/hda_multi_audio.cpp. The set_mix function 
contains something like: 
 
if mix_control has flag B_MULTI_MIX_ENABLE 
else if it has B_MULTI_MIX_GAIN 
else if it has B_MIX_MUX_MIXER 
else if it has B_MIX_MUX_SELECTOR 
 
But B_MIX_MUX_SELECTOR and B_MULTI_MIX_ENABLE are the same values. 
 
B_MIX_MUX_* are defined in an enum in hda_multi_audio.cpp itself. The B_MULTI_* 
come from defines in headers/private/audio/hmulti_audio.h.

Other related posts: