[haiku-development] Re: ***UNCHECKED*** Re: Re: Banning Barrett
- From: Dario Casalinuovo <b.vitruvio@xxxxxxxxx>
- To: haiku-development@xxxxxxxxxxxxx
- Date: Sun, 17 Mar 2019 13:35:46 +0100
Hi,
On Sun, Mar 17, 2019 at 10:22 AM Adrien Destugues <pulkomandy@xxxxxxxxx>
wrote:
I honestly don't know how should I vote. At the beginning I wanted to
vote -1, taking the above into account it would be +1. But in the end,
humdinger brings up a good point that it's not only Barrett that is
using such language.
I would give him another chance.
Btw, I always read the "huh?" as something like "I don't understand, care
to elaborate? I must be missing something?" Rather than "This does not make
sense, are you missing something obvious or completely clueless?"
In my language that sound doesn't even exist as a way to express something.
It's more like a neanderthalian sound, and sounds not very fair. I'd use
"hmm" to express doubts. Same happens for all those "shrugs", "nods" and so
on that anglophones have, which honestly took a few time for me to clearly
understand those in the context. Because that's the problem with this
stuff, they are really dependent on the context and a person mood. So I
agree with humdinger 100%.
My personal trick is to phrase my reviews as questions: "wouldn't it be
nice if the code also checked this or that?" "are you aware that this
function has unclear side effects?" "should there be some locking here?" "I
don't see when this memory is released, can you enlighten me?", "have you
considered using BAutoLock here? it would simplify the flow a lot."
I agree here too. Phrasing the phrase to be more in propositive form would
be helpful. I didn't start this way of discussing things, but probably
didn't do nothing to change that. Phrasing things like "What do you think
about ...", "what's your opinion ..." and so on is probably going to work
much better.
--
Saluti,
Dario
Other related posts:
