[haiku-development] Re: Patch for BTextControl to add the EmptyHint functionality

  • From: Barrett <barrett666@xxxxxxxxx>
  • To: haiku-development@xxxxxxxxxxxxx
  • Date: Fri, 22 Jun 2012 22:09:52 +0200

Hello,


> As for your implementation, I think you have chosen a bad approach.
> You should not use SetText, nor do you need the fEmptyHintShow
> instance variable.


I had this suspect : )


> Also I like the implementation of the HTML5 placeholder which actually
> does not disappear until you have typed something, instead of when the
> input gets focused.


From the beauty perspective i don't like the HTML5 implementation, but i
agree because when someone focus a window where the textcontrol is already
the focus view he can still read the placeholder.


> That actually makes it easier to implement,
> because basically you don't worry about the focus, just whether there
> is any text.


I'm going to rewrite the patch...thanks a lot for suggestions.

Regards

Other related posts: