[haiku-development] Re: Ok to commit these patches in Trac?

  • From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-development@xxxxxxxxxxxxx
  • Date: Sun, 10 Nov 2013 23:47:44 +0100

Hi Matt,

Am 10/11/2013 18:54, schrieb Matt Madia:
* 
http://dev.haiku-os.org/attachment/ticket/9875/0006-GridLayout.cpp-use-delete-instead-of-delete.patch

Okay.

* 
http://dev.haiku-os.org/attachment/ticket/9881/0011-Fix-size-argument-is-greater-than-the-length-of-the-.patch

The "+1" is not needed; B_FILE_NAME_LENGTH already includes the terminating null byte.

* 
http://dev.haiku-os.org/attachment/ticket/9885/0013-Use-delete-instead-of-delete.patch
* 
http://dev.haiku-os.org/attachment/ticket/9901/0017-Fix-mismatching-allocation-and-deallocation.patch

Okay.

* 
http://dev.haiku-os.org/attachment/ticket/9931/0001-Add-support-for-NULL-as-resolved_name-argument-in-re.patch

Already applied by korli.

* 
http://dev.haiku-os.org/attachment/ticket/9938/0022-Fix-memory-leak-for-threeDaysAgoMenu.patch

Okay.

* 
http://dev.haiku-os.org/attachment/ticket/9891/0014-Fix-called-C-object-pointer-is-null.patch

Not sure if that patch is needed, but it does introduce a couple of coding style issues:
* Missing space after 'if'.
* Superfluous curly braces
* Else after return

* 
http://dev.haiku-os.org/attachment/ticket/9890/0013-Fix-called-C-object-pointer-is-null.patch

Looks good.

Bye,
   Axel.

Other related posts: