[haiku-commits] Re: r43176 - haiku/trunk/src/preferences/screen
- From: "Ingo Weinhold" <ingo_weinhold@xxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Fri, 04 Nov 2011 20:28:36 +0100
John Scipione wrote:
> On Fri, Nov 4, 2011 at 4:52 AM, Axel Dörfler <axeld@xxxxxxxxxxxxxxxx> wrote:
>
> > jscipione@xxxxxxxxx wrote:
> > > - .AddStrut(controlsBox->TopBorderOffset() -
> > 1)
> > > +
> > .AddStrut(floor(controlsBox->TopBorderOffset() / 16) - 1)
> >
> > What kind of heuristic is that? The TopBorderOffset should be exactly what
> > is needed here, if it somehow isn't there must be a bug to be fixed, not
> > worked around this strange way.
>
> Can you (or maybe Ingo since he apparently wrote the code) confirm what
> TopBorderOffset is supposed to do? Right now it is difficult for me to say
> if there is a bug here or not. I think that TopBorderOffset() is suppose to
> return the distance from the top of the control to the top border in pixels
> but I'm not 100% sure.
Axel introduced the method in r16335 [1]. I only adjusted it to layout
management in r21356 -- I don't think I changed its semantics back then. My
commit message also suggests that it has actually become superfluous with
layout management.
CU, Ingo
[1] http://dev.haiku-os.org/changeset/16335
[2] http://dev.haiku-os.org/changeset/21356
Other related posts:
