[haiku-commits] Re: r42120 - haiku/trunk/src/kits/interface

  • From: Stephan Aßmus <superstippi@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 12 Jun 2011 10:18:20 +0200

Am 12.06.2011 10:14, schrieb Axel Dörfler:
Ryan Leavengood<leavengood@xxxxxxxxx>  wrote:
On Sat, Jun 11, 2011 at 10:27 PM,<anevilyak@xxxxxxxxx>  wrote:
Remove unnecessary calculations from BListView::ScrollToSelection(). At
  least I see no useful purpose to the distinction made here.
Yeah it seems silly to scroll the item to the top if the item is above
the view-port and to the bottom if it is below. Maybe this was just
pure BeOS behavior copying here?

As Stephan pointed out, this is a useful feature, and causes less confusion 
when it's done while the component is visible as it tries to keep as much of 
the originally visible area around.
Please revert.

It can still be improved, though. When more than one page is scrolled, it may be more helpful to center the scrolled to item vertically (regardless of direction). Also, to really help the user visually, scrolling would need to be animated. Maybe a second version of the method could be introduced which takes a boolean "animate" or so, while the existing version is reimplemented to call the new version with animate = false. What do others think?

Best regards,
-Stephan


Other related posts: