[haiku-commits] Re: r41089 - in haiku/trunk/src/add-ons/accelerants/radeon_hd: . atombios atombios/includes

  • From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Wed, 23 Mar 2011 11:00:23 +0100 (MET)

Philippe Houdoin<philippe.houdoin@xxxxxxxxx> wrote:
> >  SubDir HAIKU_TOP src add-ons accelerants radeon_hd ;
> >
> > +SubInclude HAIKU_TOP src add-ons accelerants radeon_hd atombios ;
> > +
> >  SetSubDirSupportedPlatformsBeOSCompatible ;
> Usually, we put SubInclude at Jamfiles bottom, not at top.

And not just out of habit: the SubDir at the top of the file actually changes 
the environment for the following statements.

> > -#include <regsdef.h> //This important file is dynamically generated based
> on the ASIC!!!!
> > +#include "regsdef.h" //This important file is dynamically generated based
> on the ASIC!!!!
> IIRC, this could also be avoid by forcing via Jamfile to search an
> explicit include file locally.
> But I may remember wrongly, as I can't quickly find how.

You can just add the path as system path, then they will be found as well.
In any case, it's always a good idea to do as little changes in the vendor code 
as possible.

Bye,
   Axel.


Other related posts: