[haiku-commits] Re: r40427 - in haiku/trunk: headers/os/package src/kits/package

  • From: Oliver Tappe <zooey@xxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 10 Feb 2011 21:49:56 +0100

Hi John,

On 2011-02-10 at 20:54:32 [+0100], John Scipione <jscipione@xxxxxxxxx> wrote:
> On Thu, Feb 10, 2011 at 2:07 PM, <zooey@xxxxxxxxxxxxxxx> wrote:
> 
[ ... ]
> > @@ -37,6 +38,8 @@
> >                        const BString&          Summary() const;
> >                        uint8                           Priority() const;
> >                        BPackageArchitecture    Architecture() const;
> > +                       const BObjectList<BString>&     LicenseNames()
> > const;
> > +                       const BObjectList<BString>&     LicenseTexts()
> > const;
> >
> 
> Wouldn't it be better to have a single list of Licenses with the name as the
> key and the text as the value rather than having to synchronize 2 separate
> lists? This seems like it could be a problem going forward.

Yes in principle, but the lists are always kept in sync because you can only 
add to them via AddLicense(name, text). There are no methods for adding to 
just one of the lists.

cheers,
        Oliver

Other related posts: