[haiku-commits] Re: r40373 - haiku/trunk/src/preferences/filetypes

  • From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 07 Feb 2011 20:09:57 +0100

superstippi@xxxxxx wrote:
> +             rightWeight = 1.0 - leftWeight;
> +     }
> +     fMainSplitView->SetItemWeight(0, leftWeight, false);
> +     fMainSplitView->SetItemWeight(1, rightWeight, true);

Since they will always add to 1, why do you have to remember and set 
them both?

> @@ -1055,8 +1068,9 @@
>  
>                               if (which == B_MIME_TYPE_DELETED
>                                       || which == B_SUPPORTED_TYPES_CHANGED
> -                                     || which == B_PREFERRED_APP_CHANGED)
> +                                     || which == B_PREFERRED_APP_CHANGED) {
>                                       _UpdatePreferredApps(&fCurrentType);
> +                             }

BTW we still never decided to do that, and I would prefer us to do so 
officially before changes like this are made.

Bye,
   Axel.


Other related posts: