[haiku-commits] Re: r40363 - haiku/trunk/src/add-ons/kernel/drivers/network/wimax/usb_beceemwmx
- From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Sat, 05 Feb 2011 18:38:15 +0100
kallisti5@xxxxxxxxxxx wrote:
> - value&=(~(1<<30));
> + clkReg &= (~(1<<30));
Almost, the << is also an operator - also, the outer parenthesis are
superfluous.
> pwmxdevice->syscfgBefFw = value;
> - if((value & 0x60)== 0)
> + if ((value & 0x60)== 0)
Not quite, again. There should be a ' ' in front of the ==, too. And
the assignment above doesn't look right, either.
> if (file_size != sizeof(VENDORCFG))
> {
file_size -> fileSize, and the { goes to the end of the preceeding
line.
> +class BeceemDevice
> :
> public BeceemNVM,
> public BeceemDDR,
We don't use spaces to indent.
The above should look like this:
class BeceemDevice : public BeceemNVM, public BeceemDDR {
> @@ -38,95 +39,100 @@
> {
>
> public:
No blank line there, and the { is wrong, too.
> +virtual ~BeceemDevice();
[...]
> +static void _ReadCallback(void
> *cookie, int32
> status,
The keywords go to the second row, not the first one.
Bye,
Axel.
Other related posts:
