[haiku-commits] Re: r40152 - haiku/trunk/src/apps/bootmanager

  • From: Ingo Weinhold <ingo_weinhold@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sat, 08 Jan 2011 16:25:43 +0100

On 2011-01-08 at 14:57:57 [+0100], axeld@xxxxxxxxxxxxxxxx wrote:
> Author: axeld
> Date: 2011-01-08 14:57:57 +0100 (Sat, 08 Jan 2011)
> New Revision: 40152
> Changeset: http://dev.haiku-os.org/changeset/40152
> 
> Modified:
>    haiku/trunk/src/apps/bootmanager/Jamfile
> Log:
> * Forgot to set the location of the bootman.bin file.
> 
> 
> Modified: haiku/trunk/src/apps/bootmanager/Jamfile
> ===================================================================
> --- haiku/trunk/src/apps/bootmanager/Jamfile    2011-01-08 13:55:11 UTC 
> (rev 40151)
> +++ haiku/trunk/src/apps/bootmanager/Jamfile    2011-01-08 13:57:57 UTC 
> (rev 40152)
> @@ -33,6 +33,7 @@
>  rule AssembleYasmBin object : source
>  {
>      SEARCH on $(source) = $(SUBDIR) ;
> +    MakeLocateArch $(object) ;
>      Depends $(object) : $(source) ;
>  }

There already is a AssembleNasm rule (which doesn't search/locate the 
source/target). I'd rather see that one support an optional parameter or 
on-target variable for the output format than define a similar rule in a 
Jamfile.

BTW, unless you used MakeLocateArch intentionally, I'd recommend 
MakeLocateDebug even if the file in question isn't debug flag dependent 
(yet).

CU, Ingo

Other related posts: