[haiku-commits] Re: r40101 - haiku/trunk/src/preferences/virtualmemory
- From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Tue, 4 Jan 2011 11:00:25 +0100 (MET)
> > +class VolumeMenuItem : public BMenuItem {
> > + public:
> > + VolumeMenuItem(const char* label, BMessage* message,
> BVolume* volume);
> > + virtual ~VolumeMenuItem();
> > + BVolume* fVolume;
> > +};
> The destructor seems useless if volume isn't owned.
In addition to that, please don't use public members, but getters instead.
Bye,
Axel.
Other related posts:
