[haiku-commits] Re: r39990 - haiku/trunk/src/preferences/printers

  • From: Rene Gollent <anevilyak@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 28 Dec 2010 16:10:41 -0500

On Tue, Dec 28, 2010 at 3:49 PM,  <michael.w.pfeiffer@xxxxxxxxx> wrote:
> -               sprintf(buffer, B_TRANSLATE("%.2f KB"), size / 1024.0);
> +               snprintf(buffer, sizeof(buffer) - 1, B_TRANSLATE("%.2f KB"),
> +                       size / 1024.0);

just FYI, the - 1 is unnecessary, snprintf implicitly reserves one
byte since it guarantees that the output will be NULL terminated.

Regards,

Rene

Other related posts: