[haiku-commits] r39929 - haiku/trunk/src/servers/app
- From: mmlr@xxxxxxxx
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Fri, 24 Dec 2010 01:58:57 +0100 (CET)
Author: mmlr
Date: 2010-12-24 01:58:57 +0100 (Fri, 24 Dec 2010)
New Revision: 39929
Changeset: http://dev.haiku-os.org/changeset/39929
Modified:
haiku/trunk/src/servers/app/ServerFont.cpp
Log:
CID 4186: The glyph_index is unsigned, so a >= 0 comparison is always true. The
"empty glyph index" as per freetype (which is eventually called) actually is 0,
so a != 0 comparison should be correct. Untested though.
Modified: haiku/trunk/src/servers/app/ServerFont.cpp
===================================================================
--- haiku/trunk/src/servers/app/ServerFont.cpp 2010-12-24 00:32:19 UTC (rev
39928)
+++ haiku/trunk/src/servers/app/ServerFont.cpp 2010-12-24 00:58:57 UTC (rev
39929)
@@ -452,7 +452,7 @@
bool ConsumeGlyph(int32 index, uint32 charCode, const GlyphCache* glyph,
FontCacheEntry* entry, double x, double y)
{
- fHasArray[index] = glyph->glyph_index >= 0;
+ fHasArray[index] = glyph->glyph_index != 0;
return true;
}
Other related posts:
- » [haiku-commits] r39929 - haiku/trunk/src/servers/app - mmlr
