[haiku-commits] r39904 - haiku/trunk/src/add-ons/kernel/bus_managers/usb

  • From: mmlr@xxxxxxxx
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 21 Dec 2010 00:24:38 +0100 (CET)

Author: mmlr
Date: 2010-12-21 00:24:38 +0100 (Tue, 21 Dec 2010)
New Revision: 39904
Changeset: http://dev.haiku-os.org/changeset/39904

Modified:
   haiku/trunk/src/add-ons/kernel/bus_managers/usb/Pipe.cpp
Log:
That the members aren't initialized in the constructor as pointed out by
Coverity was intentional (as explained by the comment). That the fInterval
member was somehow totally forgotten though, wasn't. This should only affect
EHCI and OHCI as they take the interval into account. Might fix some strange
behaviour, but most likely won't, as the interval range is rather narrow and
shouldn't be too noticeable if set incorrectly. CID 9558.


Modified: haiku/trunk/src/add-ons/kernel/bus_managers/usb/Pipe.cpp
===================================================================
--- haiku/trunk/src/add-ons/kernel/bus_managers/usb/Pipe.cpp    2010-12-20 
22:00:04 UTC (rev 39903)
+++ haiku/trunk/src/add-ons/kernel/bus_managers/usb/Pipe.cpp    2010-12-20 
23:24:38 UTC (rev 39904)
@@ -36,6 +36,7 @@
        fSpeed = speed;
        fDirection = direction;
        fMaxPacketSize = maxPacketSize;
+       fInterval = interval;
        fHubAddress = hubAddress;
        fHubPort = hubPort;
 


Other related posts:

  • » [haiku-commits] r39904 - haiku/trunk/src/add-ons/kernel/bus_managers/usb - mmlr