[haiku-commits] Re: r39407 - in haiku/trunk/src/apps/debugger: debug_info dwarf
- From: Ingo Weinhold <ingo_weinhold@xxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Fri, 12 Nov 2010 10:55:30 +0100
On 2010-11-12 at 00:58:17 [+0100], anevilyak@xxxxxxxxx wrote:
> Modified: haiku/trunk/src/apps/debugger/dwarf/DwarfExpressionEvaluator.h
> ===================================================================
> --- haiku/trunk/src/apps/debugger/dwarf/DwarfExpressionEvaluator.h
> 2010-11-11 22:47:18 UTC (rev 39406)
> +++ haiku/trunk/src/apps/debugger/dwarf/DwarfExpressionEvaluator.h
> 2010-11-11 23:58:17 UTC (rev 39407)
> @@ -57,7 +57,8 @@
> status_t Evaluate(const void* expression, size_t
> size,
> target_addr_t& _result);
> status_t EvaluateLocation(const void* expression,
> - size_t size, ValueLocation& _location);
> + size_t size, target_addr_t
> relocationDelta,
> + ValueLocation& _location);
> // The returned location will have
> DWARF
> // semantics regarding register
> numbers and
> // bit offsets/sizes (cf. bit pieces).
> @@ -71,7 +72,8 @@
> inline void _Push(target_addr_t value);
> inline target_addr_t _Pop();
>
> - status_t _Evaluate(ValuePieceLocation* _piece);
> + status_t _Evaluate(ValuePieceLocation* _piece,
> + target_addr_t relocationDelta = 0);
> void _DereferenceAddress(uint8 addressSize);
> void _DereferenceAddressSpaceAddress(
> uint8 addressSize);
I'd much rather see the relocation offset added to the
DwarfExpressionEvaluationContext (inline).
CU, Ingo
Other related posts:
