[haiku-commits] Re: r38920 - haiku/trunk/src/system/boot/platform/amiga_m68k
- From: François Revol <revol@xxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Sun, 10 Oct 2010 22:20:15 +0200
Le 10 oct. 2010 à 22:11, Oliver Tappe a écrit :
>
>>>
>>>> + * Contains prototypes & macros from the Amiga SDK:
>>>> +**
>>>
>>> Eeek.
>>>
>>>> +#ifndef __ASSEMBLER__
>>>> +
>>>> +typedef void *APTR; /* 32-bit untyped pointer */
>>>> +
>>>> +typedef long LONG; /* signed 32-bit quantity */
>>>> +typedef unsigned long ULONG; /* unsigned 32-bit quantity */
>>>> +typedef unsigned long LONGBITS; /* 32 bits manipulated
>>>> individually */
>>>> +typedef short WORD; /* signed 16-bit quantity */
>>>
>>> That is really quite ugly.
>>> Why not just rewrite the headers with the native types instead? (that
>>> would also get rid of the copyright)
>>
>> B_TOO_LAZY :p
>>
>> Will see, but I want to have something working :p
>
> There's simply no excuse for committing code that possibly has copyright
> problems or that violates the styleguide. If you want to experiment with
> code in rough state, fair enough, but you can do that in a private
> git/mercurial or whatever repo.
>
> It doesn't make sense if we force every external patch to conform to the
> styleguide before looking at it closely if people with commit rights
> violate the style on a more or less regular basis and put forward pretty
> much lame excuses ...
Copyright on headers (which define an interface) is a non-sense anyway but oh
well...
At least the macros generated by fd2pragma should not be considered
copyrighted...
François.
Other related posts: