[haiku-commits] Re: r38878 - haiku/trunk/src/apps/expander
- From: "Clemens Zeidler" <clemens.zeidler@xxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Mon, 04 Oct 2010 10:33:30 +1300
Am 04.10.2010, 10:02 Uhr, schrieb <korli@xxxxxxxxxxxxxxxx>:
Author: korli
Date: 2010-10-03 23:02:47 +0200 (Sun, 03 Oct 2010)
New Revision: 38878
Changeset: http://dev.haiku-os.org/changeset/38878
Modified:
haiku/trunk/src/apps/expander/ExpanderWindow.cpp
Log:
* 7zip asks for a password on the stdout, we check for the "Enter
password" string.
Wouldn't it be better to move the out, err handling into a separate class,
maybe ExpanderRule for now? Looks a little bit ugly to handle it for every
format in the main window.
In the long term a more abstract expander format class would be
appropriated which would also be able to use expander libs instead of just
the executables. This class could also be outsourced into add-ons...
Just take a short look at the source, sorry if I miss something.
Regards,
Clemens
Other related posts:
