[haiku-commits] Re: r38712 - in haiku/trunk/headers/posix: net sys

  • From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 19 Sep 2010 14:41:45 +0200

scott mc <scottmc2@xxxxxxxxx> wrote:
> Log:
> Readded parameter names, taking them from the ones used at opengroup,
> except for sockatmark for which I used descriptor instead of "s".

Much better, though please follow our coding style instead of using 
OpenGroup names.

> -char* if_indextoname(unsigned, char* nameBuffer);
> +char* if_indextoname(unsigned ifindex, char* nameBuffer);

That would be ifIndex at best (rather interfaceIndex).

> -int statvfs(const char *, struct statvfs *);
> -int fstatvfs(int, struct statvfs *);
> +int statvfs(const char *path, struct statvfs *buf);
> +int fstatvfs(int fildes, struct statvfs *buf);

buf -> buffer, fildes either to "fd" which we are using quite often, or 
the more verbose "descriptor" you used earlier.

Bye,
   Axel.


Other related posts: