[haiku-commits] Re: r38547 - haiku/trunk/src/add-ons/kernel/bus_managers/ata

  • From: Jérôme Duval <korli@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 6 Sep 2010 21:25:24 +0200

2010/9/6 Stephan Assmus <superstippi@xxxxxx>:
>> 2010-09-06 18:45:48 UTC (rev 38546)
>> +++ haiku/trunk/src/add-ons/kernel/bus_managers/ata/ATADevice.cpp
>> 2010-09-06 18:53:47 UTC (rev 38547)
>> @@ -148,8 +148,12 @@
>>        // the following fields are *much* to small, sigh...
>>        memcpy(data.vendor_ident, fInfoBlock.model_number,
>>                sizeof(data.vendor_ident));
>> +       swap_words(data.vendor_ident, sizeof(data.vendor_ident));
>> +
>>        memcpy(data.product_ident, fInfoBlock.model_number + 8,
>>                sizeof(data.product_ident));
>> +       swap_words(data.product_ident, sizeof(data.product_ident));
>> +
>>        memcpy(data.product_rev, "    ", sizeof(data.product_rev));
>>
>>        uint32 allocationLength = command->allocation_length;
>
> Is this change also valid for big endian systems?
>

Indeed. I modified the swap_words() function in r38552.

Bye,
Jérôme

Other related posts: