[haiku-commits] Re: r38122 - in haiku/trunk: headers/os/interface src/bin
- From: François Revol <revol@xxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Sun, 15 Aug 2010 23:09:25 +0200
Le 15 août 2010 à 22:29, Stephan Assmus a écrit :
>> Well I do have code that use them :p
>
> Then please #ifdef __HAIKU__, we should not add cruft that potentially
> irritates people.
Actually it did irritate me seeing build breakage here :P
>> Btw, we lack more also...
>>
>> At least one for the (inactive) window border.
>>
>> Also, the input method colors should probably be here as well instead of
>> hardcoding them.
>
> Less is more, IMHO. Most colors can be derived from a few user selectable
> ones. No need for all the fiddling.
Except what I saw in BControlLook makes it hard to use with some colors for now.
In some places it checks if the color is too dark and does different things,
but not everywhere.
IIRC Dano used the SHINE and SHADOW colors as base for tints.
Having those swapped with dark colors would make things readable at least even
if breaking the semantics of "DARKEN" or "LIGHTEN".
Maybe we could add a level check in tint_color() triggered by negated tints.
A good test candidate is the "Matrix2" theme which has black background. :p
(Yes I do know theming is not advertised for the official distro, but remember
we want distros to be able to distinguish themselves from the official one, and
this is one mean to it. Also, integrators might want to use custom themes, like
TuneTracker. In fact I already have a TuneTracker theme around already :p)
François.
Other related posts:
