[haiku-commits] Re: r37939 - haiku/trunk/src/servers/app
- From: Stefano Ceccherini <stefano.ceccherini@xxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Fri, 6 Aug 2010 18:21:30 +0200
2010/8/6 Stephan Assmus <superstippi@xxxxxx>:
>
> On 2010-08-06 at 14:21:34 [+0200], michael.w.pfeiffer@xxxxxxxxx wrote:
>> Author: laplace
>> Date: 2010-08-06 14:21:34 +0200 (Fri, 06 Aug 2010)
>> New Revision: 37939
>
>> @@ -2783,17 +2783,14 @@
>> if (link.Read<BPoint>(&where) == B_OK) {
>> ServerPicture* picture = App()->GetPicture(token);
>> if (picture != NULL) {
>> - // Setting the drawing origin outside of the
>> - // state makes sure that everything the picture
>> - // does is relative to the global picture offset.
>> - BPoint origin = fCurrentView->DrawingOrigin();
>> + fCurrentView->PushState();
>
> Please add the comment back. It was put there, because someone thought the
> code could be simplified in the past, i.e. what the code does it not obvious
> to the casual reader.
>
> Best regards,
> -Stephan
>
Stephan, could you have a look at what I wrote in ticket #6415,
comment 10, and comment about it ?
Thank you in advance!
Other related posts:
