[haiku-commits] Re: r37936 - haiku/trunk/headers/os/net

  • From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Fri, 06 Aug 2010 15:10:22 +0200

Stephan Assmus <superstippi@xxxxxx> wrote:
> > +class BNetworkRoster {
> > +public:
> > +            BNetworkRoster&        Default();
> -> static

Oops.

> > +
> > +            uint32                CountInterfaces();
> const? Also while uint32 makes more sense, it's usually int32 in the 
> rest of 
> the Be API.

Yes, that one should probably be const - it's just that if we wanted to 
buffer the data, it's at that point that we could do it.
I can change the index type to int32.

> > +            BNetworkInterface*    InterfaceAt(uint32 index);
> const?

Same as above.

Bye,
   Axel.


Other related posts: