[haiku-commits] Re: r36932 - haiku/trunk/src/add-ons/media/media-add-ons/video_mixer

  • From: Stephan Assmus <superstippi@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 25 May 2010 11:37:06 +0200

Hi,

On 2010-05-25 at 11:26:21 [+0200], David McPaul <dlmcpaul@xxxxxxxxx> wrote:
> On 25 May 2010 19:07, Stephan Assmus <superstippi@xxxxxx> wrote:
> > On 2010-05-25 at 11:06:26 [+0200], dlmcpaul@xxxxxxxxx wrote:
> >> Author: dlmcpaul
> >> Date: 2010-05-25 11:06:26 +0200 (Tue, 25 May 2010)
> >> New Revision: 36932
> >> Changeset: http://dev.haiku-os.org/changeset/36932/haiku
> >>
> >> Modified:
> >>    haiku/trunk/src/add-ons/media/media-add-ons/video_mixer/BufferMixer.cp
> >>    p
> >>    haiku/trunk/src/add-ons/media/media-add-ons/video_mixer/BufferMixer.h
> >>    haiku/trunk/src/add-ons/media/media-add-ons/video_mixer/VideoMixerNode
> >>    Con
> >>    sumer.cpp
> >> Log:
> >> gcc4 fixes and add removal of buffer when source disconnected
> >
> > David, you should really know the style guide by now, it's annoying when 
> > new
> > code gets checked in that violates the style.
> 
> I check and fix what I see, beyond that I don't have time.

If I came across rude, that was not my intention, I was just trying to be 
brief, because I also don't have so much time. I hope you see the value in a 
clean codebase that follows the same style all across.

Best regards,
-Stephan

Other related posts: