[haiku-commits] Re: r36453 - haiku/trunk/src/kits/interface
- From: Ingo Weinhold <ingo_weinhold@xxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Mon, 03 May 2010 23:21:59 +0200
On 2010-04-24 at 19:48:13 [+0200], anevilyak@xxxxxxxxx wrote:
> Author: anevilyak
> Date: 2010-04-24 19:48:13 +0200 (Sat, 24 Apr 2010)
> New Revision: 36453
> Changeset: http://dev.haiku-os.org/changeset/36453/haiku
> Ticket: http://dev.haiku-os.org/ticket/3267
>
> Modified:
> haiku/trunk/src/kits/interface/Menu.cpp
> Log:
> Don't set releasedOnce unless we actually detect an appropriate change in
> mouse button states. Otherwise we could mistakenly invoke menu items when
> not desired. Fixes the other part of #3267.
>
> Modified: haiku/trunk/src/kits/interface/Menu.cpp
> ===================================================================
> --- haiku/trunk/src/kits/interface/Menu.cpp 2010-04-24 16:56:22 UTC (rev
> 36452)
> +++ haiku/trunk/src/kits/interface/Menu.cpp 2010-04-24 17:48:13 UTC (rev
> 36453)
> @@ -1628,8 +1628,6 @@
> } else if (item != NULL) {
> _UpdateStateOpenSelect(item, location, navAreaRectAbove,
> navAreaRectBelow, selectedTime, navigationAreaTime);
> - if (!releasedOnce)
> - releasedOnce = true;
> } else if (_OverSuper(screenLocation)) {
> fState = MENU_STATE_TRACKING;
> UnlockLooper();
What about this change? I really can't judge whether it is OK or not. The
comments in the ticket suggest it didn't help. Anyone?
CU, Ingo
Other related posts:
