[haiku-commits] Re: r36392 - haiku/trunk/src/apps/mediaplayer
- From: Ingo Weinhold <ingo_weinhold@xxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Thu, 22 Apr 2010 15:27:22 +0200
On 2010-04-22 at 14:17:29 [+0200], Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
wrote:
> Ingo Weinhold <ingo_weinhold@xxxxxx> wrote:
> > > - fController->TogglePlaying();
> > > + BAutolock _(fPlaylist);
> > > + if (fPlaylist->CurrentItemIndex() < 0) {
> > > + // No valid playlist item - start again from the first one
> > > + fPlaylist->SetCurrentItemIndex(0);
> > > + } else
> > > + fController->TogglePlaying();
> > > }
> > I don't quite see why this would start playing, if paused before.
>
> If it was actually paused there is a valid playlist item, ie. the
> current item index is >= 0.
But then I don't see why this change would fix the ticket. The >= 0 case is
unchanged and the other case (if there is a play list item at all) wouldn't
start playing anymore. I just tested r36408 and can confirm that the
behavior is still (or maybe differently?) broken. Hitting "play" after the
song played to its end starts playing the song, but the seek marker is
stuck at the end.
I'm not familiar with the code, so I don't really know what should be done
here. Maybe Stippi can comment.
CU, Ingo
Other related posts:
