[haiku-commits] Re: r36391 - haiku/trunk/src/apps/mediaplayer
- From: "Stephan Assmus" <superstippi@xxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Wed, 21 Apr 2010 17:21:01 +0200
Hi,
Axel wrote:
> "Stephan Assmus" <superstippi@xxxxxx> wrote:
> > > if (!hadNext) {
> > > - if (fHasVideo) {
> > > - if (fCloseWhenDonePlayingMovie)
> > > - PostMessage(B_QUIT_REQUESTED);
> > > - } else {
> > > - if (fCloseWhenDonePlayingSound)
> > > - PostMessage(B_QUIT_REQUESTED);
> > > - }
> > > + if ((fHasVideo && fCloseWhenDonePlayingMovie)
> > > + || (fHasAudio &&
> > > fCloseWhenDonePlayingSound))
> > > + PostMessage(B_QUIT_REQUESTED);
> > > }
> > I have not yet looked closely at the rest of the patch, but the above
> > "cleanup"
> > is not equivalent. Now it will close movies when the setting
> > fCloseWhenDonePlayingSound is true.
>
> Ah, so fHasAudio is usually always true. Will fix that.
If a movie has audio, too, then yes. :-)
Best regards,
-Stephan
Other related posts:
