[haiku-commits] Re: r35121 - haiku/trunk/src/servers/media_addon

  • From: Jérôme Duval <korli@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 17 Jan 2010 21:14:03 +0100

2010/1/17 Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>:
> korli@xxxxxxxxxxxxxxxx wrote:
>> * I had to reverse the addons iteration when quitting, the mixer
>> wasn't releasing correctly if released last.
>
> Why? I mean, what was the problem?

Media nodes deletion is triggered by the media server when refcount is
zero. It sends a message to the media node  port, which then asks the
media roster to delete the media node.
When quitting the media_addon server, there could still be references
to nodes hosted by the addon server: the roster looper could still try
to delete media nodes whereas the addons are already unloaded.

I tried to solve this problem in 35133 by releasing all references to
have the media nodes deleted (multiaudio settings are then saved
correctly). I noticed the Media preferences keep references on some
nodes.
Is there a better way ?

Bye,
Jérôme

Other related posts: