[haiku-commits] Re: r35104 - in haiku/trunk: build/jam data/system/boot src/apps/text_search src/system/kernel/fs src/system/libroot/os ...
- From: Stephan Assmus <superstippi@xxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Tue, 19 Jan 2010 20:26:45 +0100
On 2010-01-19 at 19:37:17 [+0100], Urias McCullough <umccullough@xxxxxxxxx>
wrote:
> On Tue, Jan 19, 2010 at 10:31 AM, Stephan Assmus <superstippi@xxxxxx>
> wrote:
> > Good points. I already forgot about this problem, but I'll try to fix
> > it ASAP. Although I think it's not good manners to go about changing
> > something without pressing need and then not making sure it works as
> > good before, even though the culprit is code that wasn't written nicely
> > to begin with. ;-)
>
> Yeah, the current solution looked weak (I realize I didn't make a
> complete sentence in my previous email).
>
> Should I file a ticket as a reminder? or do you plan to take care of
> sometime in the next 24 hours? ;)
No need, it's fixed now. And indeed the current solution was totally
adequate and could not work any other way. That's because Installer needs
to support source volumes other than /boot. It cannot use find_directory(),
since find_directory will (rightfully) ignore the volume passed for most
folders other than "trash". The current solution was the speediest way to
check each and every entry to be copied in the recursive methods. :-)
Best regards,
-Stephan
Other related posts:
