[haiku-commits] Re: r35098 - haiku/trunk/src/system/libroot/posix/pthread

  • From: Jérôme Duval <korli@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 18 Jan 2010 19:01:24 +0100

2010/1/17 Ingo Weinhold <ingo_weinhold@xxxxxx>:
> Not sure this is a good solution, as in such a case the pthread structure
> might already have been deleted and checking the flags would potentially
> access invalid memory. The _start() incompatibility leading to #5271 was
> introduced in r3108, BTW. I'm not quit sure about the reasoning, why exit()
> (or _start()) would call _thread_do_exit_notifcation() for the current
> thread and none of the others. I think we should just remove that call in
> exit() and _start(), rename _thread_do_exit_notifcation(), and create an
> empty stub with the old name for binary compatibility.

I understand it's called for every user  spawned thread on exit.
Agreed. I did so in r35142.


Bye,
Jérôme

Other related posts: