[haiku-commits] Re: r35065 - haiku/trunk/src/kits/tracker

  • From: Rene Gollent <anevilyak@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 14 Jan 2010 08:24:04 -0600

On Thu, Jan 14, 2010 at 1:58 AM, Axel Dörfler <axeld@xxxxxxxxxxxxxxxx> wrote:
> Since the paths are compared afterwards, you could even compare it like
> this:
>
> {
>        BPath path;
>        status_t result = find_directory(B_DESKTOP_DIRECTORY, &path, true);
>        if (result != B_OK)
>                return false;
>
>        BEntry desktopEntry(path.Path());
>        return *entry == desktopEntry;
> }

Indeed that'd be simpler :) Will change that after work in a few hours
unless you want to do so first :) By the way, I started working on
relocating the Trash dir and have it mostly working, but ran into one
snag I could use a second mind on how to best resolve: Right now, the
DeskWindow receives the context menu click and decides whether or not
the trash menu or a regular pose context menu needs to be shown. That
part is easily dealt with since that functionality can just be
relocated to ContainerWindow. However, the problem becomes, if we make
the Trash a (removable) symlink on the desktop, then which menu do we
show? If I show the Trash menu, then the options to remove / rename /
etc. the symlink are unavailable, but if I show the normal menu then I
can't empty the trash via right click from the desktop. I'm debating
modifying it so it can just add the trash-related items as a
subsection of the normal context menu but I'm not sure if that's
ideal. Thoughts?

Regards,

Rene

Other related posts: