[haiku-commits] Re: r34650 - haiku/trunk/src/kits/media
- From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Sun, 13 Dec 2009 14:38:26 +0100
dlmcpaul@xxxxxxxxx wrote:
> Log:
> switch to use STL containers, limit to 10 cache entries
I'm not really happy with this part of the change. Why did you do this?
It's less efficient, and you don't do any error checking. Besides, the
list is not part of rtm memory, and could therefore be swapped out
theoretically.
Furthermore, one of the point of rewriting this was to get rid of the
low chunk limit (10 chunks is really practically nothing for our mp3
reader).
Please revert this again.
> don't clear cache on findkeyframe
Why not? How is that supposed to work? You will now get outdated chunk
data after seeking.
> report error conditions better.
Where?
> This makes video work again
What change exactly makes video work again?
Bye,
Axel.
Other related posts:
