[haiku-commits] Re: r34301 - haiku/trunk/src/data/beos_mime/image
- From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Fri, 27 Nov 2009 10:10:28 +0100
"Humdinger" <humdingerb@xxxxxxxxxxxxxx> wrote:
> -- axeld@xxxxxxxxxxxxxxxx, on Fri, 27 Nov 2009 08:56:41 +0100 (CET):
> > +resource(2, "META:SNIFF_RULE") "0.5 (\"\\012\\005\\001\") [3](0x01
> > |
> > 0x04 | 0x08)";
> > + // version 5, encoding 1 is all our translator currently
> > supports
> Thanks! I didn't really get the priority setting and was just about
> trying to grok what's in sniffer's Parser.h... :)
It's really not that easy to understand. I guess someone should write
nice documentation, or add a few more examples (there already is some
documentation in src/kits/storage/MimeType.cpp for CheckSnifferRule()).
> I was wondering: Even if it's not supported by the translator,
> shouldn't non-version 5 PCX still be recognized as image/x-pcx? They
> are still PCX images.
Since we didn't receive any complaints about that so far, I would guess
that these PCX images are even more rare than PCX images in general.
Since this considerably improves the quality of the sniffer rule, and
the .pcx extension will work out alone as well, I would just keep it as
is.
> If the translator can't handle the version, it should say so.
What do you mean by that?
Bye,
Axel.
Other related posts:
