[haiku-commits] Re: r33923 - haiku/trunk/src/apps/deskcalc
- From: "Alexandre Deckner" <alex@xxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Fri, 06 Nov 2009 19:06:18 +0000
"Ingo Weinhold" <ingo_weinhold@xxxxxx> wrote:
>
> > if (message->FindData("text/plain", B_MIME_TYPE,
> > (const void**)&text, &numBytes) == B_OK) {
> > }
>
> That's the way I'd indent those, too.
Ok, same here, that's what i did, though i still had doubts about that
simpler if.
> >
> > ret = archive->AddData("rgbDisplay", B_RGB_COLOR_TYPE,
> > &fExpressionBGColor, sizeof(rgb_color));
> >
> > lightness = (fExpressionBGColor.red
> > + fExpressionBGColor.green + fExpressionBGColor.blue) / 3;
>
> In both cases I would only indent one level, since unlike in an if
> statement things end with the second line and the additional
> indentation
> level doesn't really add to the readability.
Ok, that's what i did too.
> To make the subexpressions
> more obvious in the second case I would indent two levels, if the
> expression continued on the next line, though.
I agree.
I'll drop a line/examples about those cases in the guidelines.
Regards,
Alex
Other related posts:
