[haiku-commits] haiku: hrev56234 - src/apps/stylededit

  • From: waddlesplash <waddlesplash@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 30 Jun 2022 15:38:44 +0000 (UTC)

hrev56234 adds 1 changeset to branch 'master'
old head: 946bd9ab3c42e2966d955dadf8fdc04ece51dc92
new head: 3571cd8a6b9926007a6ac1fdefa9a46c4c0caaec
overview: 
https://git.haiku-os.org/haiku/log/?qt=range&q=3571cd8a6b99+%5E946bd9ab3c42

----------------------------------------------------------------------------

3571cd8a6b99: StyledEdit: Add comment explaining MakeFocus() loc
  
  ... to explain hrev562209 by Jim906 which fixes #17733
  StyledEdit: give initial focus to the TextView
  
  No functional change
  
  Change-Id: Id428290d8d3530e5ef9213489625c1968984d323
  Reviewed-on: https://review.haiku-os.org/c/haiku/+/5422
  Tested-by: Commit checker robot <no-reply+buildbot@xxxxxxxxxxxx>
  Reviewed-by: nephele <nep@xxxxxxxxxxxxxx>
  Reviewed-by: waddlesplash <waddlesplash@xxxxxxxxx>

                                     [ John Scipione <jscipione@xxxxxxxxx> ]

----------------------------------------------------------------------------

Revision:    hrev56234
Commit:      3571cd8a6b9926007a6ac1fdefa9a46c4c0caaec
URL:         https://git.haiku-os.org/haiku/commit/?id=3571cd8a6b99
Author:      John Scipione <jscipione@xxxxxxxxx>
Date:        Thu Jun 30 03:11:38 2022 UTC
Committer:   waddlesplash <waddlesplash@xxxxxxxxx>
Commit-Date: Thu Jun 30 15:38:41 2022 UTC

Ticket:      https://dev.haiku-os.org/ticket/17733

----------------------------------------------------------------------------

1 file changed, 2 insertions(+), 1 deletion(-)
src/apps/stylededit/StyledEditWindow.cpp | 3 ++-

----------------------------------------------------------------------------

diff --git a/src/apps/stylededit/StyledEditWindow.cpp 
b/src/apps/stylededit/StyledEditWindow.cpp
index cb8f3f822d..f5ab506d9b 100644
--- a/src/apps/stylededit/StyledEditWindow.cpp
+++ b/src/apps/stylededit/StyledEditWindow.cpp
@@ -1366,8 +1366,9 @@ StyledEditWindow::_InitWindow(uint32 encoding)
        .End();
 
        SetKeyMenuBar(mainMenu);
-       fTextView->MakeFocus(true);
 
+       // must focus text view after window layout is built
+       fTextView->MakeFocus(true);
 }
 
 


Other related posts:

  • » [haiku-commits] haiku: hrev56234 - src/apps/stylededit - waddlesplash