[haiku-commits] haiku: hrev56177 - src/libs/compat/freebsd_network

  • From: waddlesplash <waddlesplash@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 9 Jun 2022 22:55:34 +0000 (UTC)

hrev56177 adds 1 changeset to branch 'master'
old head: 9690b012b467828662af0bcc7d12cdf32f32cfcc
new head: 3c5b619e97bebc8e75a477f23fe385ed7e4d5374
overview: 
https://git.haiku-os.org/haiku/log/?qt=range&q=3c5b619e97be+%5E9690b012b467

----------------------------------------------------------------------------

3c5b619e97be: freebsd_network: Remove unneeded frees of if_l2com.
  
  After 458c40fb2787fde1b9363cb43d15941591a7b923, if_l2com is not
  allocated anymore, but I missed deleting these at that time.

                              [ Augustin Cavalier <waddlesplash@xxxxxxxxx> ]

----------------------------------------------------------------------------

Revision:    hrev56177
Commit:      3c5b619e97bebc8e75a477f23fe385ed7e4d5374
URL:         https://git.haiku-os.org/haiku/commit/?id=3c5b619e97be
Author:      Augustin Cavalier <waddlesplash@xxxxxxxxx>
Date:        Thu Jun  9 22:55:17 2022 UTC

----------------------------------------------------------------------------

1 file changed, 1 insertion(+), 13 deletions(-)
src/libs/compat/freebsd_network/if.c | 14 +-------------

----------------------------------------------------------------------------

diff --git a/src/libs/compat/freebsd_network/if.c 
b/src/libs/compat/freebsd_network/if.c
index b9f347189f..a662b275d0 100644
--- a/src/libs/compat/freebsd_network/if.c
+++ b/src/libs/compat/freebsd_network/if.c
@@ -175,7 +175,7 @@ if_alloc_inplace(struct ifnet *ifp, u_char type)
        if (ifindex_alloc_locked(&index) != ENOERR) {
                IFNET_WUNLOCK();
                panic("too many devices");
-               goto err3;
+               goto err2;
        }
        ifnet_setbyindex_locked(index, IFNET_HOLD);
        IFNET_WUNLOCK();
@@ -186,13 +186,6 @@ if_alloc_inplace(struct ifnet *ifp, u_char type)
        IF_ADDR_LOCK_INIT(ifp);
        return 0;
 
-err3:
-       switch (type) {
-               case IFT_ETHER:
-                       _kernel_free(ifp->if_l2com);
-                       break;
-       }
-
 err2:
        delete_sem(ifp->receive_sem);
 
@@ -229,11 +222,6 @@ if_free_inplace(struct ifnet *ifp)
        IFNET_WUNLOCK();
 
        IF_ADDR_LOCK_DESTROY(ifp);
-       switch (ifp->if_type) {
-               case IFT_ETHER:
-                       _kernel_free(ifp->if_l2com);
-                       break;
-       }
 
        delete_sem(ifp->receive_sem);
        ifq_uninit(&ifp->receive_queue);


Other related posts:

  • » [haiku-commits] haiku: hrev56177 - src/libs/compat/freebsd_network - waddlesplash